Feat/register phpinfo entries - #2578
Conversation
|
@dunglas I think we should revert the last commit and make not passing the |
|
For watcher, this is because of e-dant/watcher#102 |
33a4a54 to
f1f8ca5
Compare
f1f8ca5 to
f06d146
Compare
|
@dunglas I'm not sure if we really should rename |
|
I'm not sure either but this sounds more idiomatic to me. People who will call this function will do it in Go, it in PHP. |
|
Alright, I'm okay with it like this either way. |
|
Reminder to self: cli registration logic is now split between <= 8.5 and >= 8.6. Needs a rebase. |
…_entries # Conflicts: # cli.go # cli_test.go # frankenphp.c
|
Cli registration now works in both paths (<=8.5 and >=8,.6). Last commit is technically unrelated to the branch, I just got tired of the tests failing locally due to my ini settings. |
2 participants
closes #2576
Edit: the entries are sorted now.
@dunglas I know you've worked on the watcher-go library before, perhaps you could expose a proper version number instead?